nesicide icon indicating copy to clipboard operation
nesicide copied to clipboard

Fix rc2qt hex decoding, remove Python-style b'' from C++ output

Open nyanpasu64 opened this issue 6 years ago • 6 comments

The resulting cqtmfc_famitracker.cpp is identical to the outdated version from master.

nyanpasu64 avatar Jun 22 '19 04:06 nyanpasu64

I have a script to regenerate cqtmfc_famitracker.cpp:

#!/bin/sh
cd $(git rev-parse --show-toplevel)

python tools/rc2qt/rc2qt.py \
       libs/famitracker/FamiTracker.rc \
       > libs/famitracker/cqtmfc_famitracker.cpp

Should I add this to master? I'm currently using my own version (adapted for j0cc) on my unfinished j0cc branch.

nyanpasu64 avatar Jun 22 '19 04:06 nyanpasu64

Yes, please merge that script.

christopherpow avatar Jun 22 '19 14:06 christopherpow

pushed again? the presence of the broken script in master makes me uncomfortable.

nyanpasu64 avatar Jun 27 '19 07:06 nyanpasu64

What broken script?

christopherpow avatar Jun 27 '19 13:06 christopherpow

the .py in master is broken and produces incorrect output.

nyanpasu64 avatar Jun 27 '19 16:06 nyanpasu64

Fixed.

On Thu, Jun 27, 2019 at 11:22 AM jimbo1qaz [email protected] wrote:

the .py in master is broken and produces incorrect output.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/christopherpow/nesicide/pull/43?email_source=notifications&email_token=AAMQR4A34XJ2IA3UHZ5S5LLP4TSNJA5CNFSM4H2V7A72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYXUX7Y#issuecomment-506416127, or mute the thread https://github.com/notifications/unsubscribe-auth/AAMQR4AACVYCL22BUXFIXFTP4TSNJANCNFSM4H2V7A7Q .

christopherpow avatar Jun 28 '19 15:06 christopherpow