pygamma icon indicating copy to clipboard operation
pygamma copied to clipboard

Published 20 hours ago • verified publisher icon christopherpoole

signed gamma evaluation

Open christopherpoole opened this issue 11 years ago • 2 comments

Is the current implementation correct? The determination of the sign should probably be calculated between the sample and the value closest to it in the reference under the distance footprint, rather than a straight diff of the sample and the reference?

christopherpoole avatar Mar 03 '13 03:03 christopherpoole

Your gamma_evaluation is nice and compact, but somewhat difficult to understand. Can you put some more comments in?

In the JoMP paper, it looks like they are just determining the sign from the un-shifted points.

roycoding avatar Mar 09 '13 08:03 roycoding

I have added a few comments to the code.

christopherpoole avatar Mar 13 '13 04:03 christopherpoole