banner-generator icon indicating copy to clipboard operation
banner-generator copied to clipboard

:sparkles: Add option to upload background image

Open diveresque opened this issue 5 years ago • 3 comments

Using react-dropzone and FileReader to allow user to upload image from computer onto background-image of the banner #5

diveresque avatar Jul 25 '19 10:07 diveresque

Hi @christopherkade have done the basics for upload images, needs a bit of tweaking, but thought its good to get some feedback at this point.

Also the checks didnt work as you can see - the error says to run yarn add react-dropzone, is that correct?

diveresque avatar Jul 25 '19 10:07 diveresque

This is awesome work, I've been fiddling around with it and you did a great job.
Make sure to remove package-lock.json, we already have a yarn.lock 😄

I've done a code review, most of these changes are tiny so don't worry if you see so many comments !

christopherkade avatar Aug 04 '19 19:08 christopherkade

Thanks for the feedback, I am going through these. Im happy about the many comments, its good to learn! :D

diveresque avatar Aug 07 '19 11:08 diveresque