remixings
remixings copied to clipboard
Duplicate values
Great mixins, thanks!
Issue:
.margin(10px, 10px);
duplicate values:
margin: 10px 10px;
margin: 1rem 10px;
margin: 10px 1rem;
margin: 1rem 1rem;
whith padding(10px, 10px) same issue
Solution: add condition not
.margin(@vertical, @horizontal)
when (ispixel(@vertical)) and not (ispixel(@horizontal)){
@rem-value: ~`pxtorem('@{vertical}')`;
.margin(@rem-value, @horizontal);
}
.margin(@vertical, @horizontal)
when (ispixel(@horizontal)) and not (ispixel(@vertical)){
@rem-value: ~`pxtorem('@{horizontal}')`;
.margin(@vertical, @rem-value);
}
same for padding
but it would be better to implement solution from Anton Syuvaev