Chris de Graaf

Results 150 comments of Chris de Graaf

Man, GH's permissions are laughable... :(

There are ways that we could get read permissions by default and only prompt for a writable token when needed, but I think it's probably more work than it's worth...

There's also outside collaborators to think about.

Yeah but you can't do that check without push access of your own...

I'm an outside collaborator on PkgTemplates, I also have repos owned by me with collaborators. I don't think it's very uncommon.

> Have the option of granting write access, but don't require it If you mean what I think you mean, then this is what I meant to when I mentioned...

Some things that would reduce friction a lot: - Pkg inserting `[compat]` entries at `add` time. - Pkg having a `freeze` command that adds a lower bound for each dependency...

Looks like GitLab has changed their datetime format...

Upon further inspection, GitLab actually returns different formats depending on what you're accessing, which is... not ideal. Fixing it requires a non-trivial patch to GitForge, so I guess I should...

Turns out this is already mentioned here: https://github.com/christopher-dG/GitForge.jl/pull/14 But hacking something into JSON2 is not the right fix IMO. Not really sure what to do but I'll think about it.