Christophe Bedard
Christophe Bedard
> Cant they fix it by doing what `git commit --signoff` would do when they made the commit like how you would expect? yeah, it should be an easy fix!
> @christophebedard A multiple CI jobs failing. > > Does this PR still WIP? Yes, sorry! I expected it to work, but it doesn't work and I haven't had time...
@nnmm sorry, I don't :/ I've found debugging GitHub Windows CI to be quite frustrating unfortunately and have not had time to really dive deep into it.
> Seems fine if it works! It doesn't :(
Thanks for bringing this up! I'm not sure what upgrading to a more recent version entails other than modifying this line: https://github.com/ros-tooling/setup-ros/blob/16c95b566a82852112e58201d9cf69044c12b29b/action.yml#L41 but I can look into it some time...
Great, thanks for the info! I'll do that and update the version in the CI configs as well.
I've created PRs for `setup-ros` and `action-ros-ci`: https://github.com/ros-tooling/setup-ros/pull/521 and https://github.com/ros-tooling/action-ros-ci/pull/778. A lot of the local CI jobs are failing due to an issue with permissions. Something like this: https://github.com/cypress-io/github-action/issues/446. I'll...
> You may have to install sudo to make the action work. Can you share an example GitHub action config where this would be necessary? I'm guessing this is only...
Sounds reasonable to me. A PR would be appreciated :grin:
Looking at the workflow logs, it looks like the `ament_cmake_export_assemblies` package (from https://github.com/ros2-dotnet/ament_cmake_export_assemblies) depends on `catkin_pkg`. Usually, `rosdep` would install all packages' dependencies, but it doesn't support Windows, so you...