Christophe Bedard

Results 192 comments of Christophe Bedard

Not sure about the ETA. I've started working on it for `setup-ros` (but don't have much time), but for `setup-ros-docker` it would probably be way quicker, since we only need...

We're happy to review a PR that adds this functionality! You could add a `use-catkin` option. If `true`, some `colcon`-specific options such as `colcon-defaults`, `colcon-mixin-repository`, and `colcon-extra-args` would not have...

The problem is that there is currently no active maintainer for `vcstool`. This will not get fixed without someone submitting a PR to the `vcstool` repo with a fix, but...

Migration steps are mentioned here https://github.com/typicode/husky/releases/tag/v9.0.1

> Looks like husky is up-to-date now, so this is no longer needed. Oh, well, all good. You should have noticed that sooner, bot.

I've updated this PR to reflect the decision in https://github.com/ros2/rclcpp/pull/2475#discussion_r1550080593 to not deprecate `spin_until_future_complete` and not have `spin_until_complete` accept both a future and a condition.

@fujitatomoya could you review this? This reflects the new changes to https://github.com/ros2/rclcpp/pull/2475, which should be final-ish now.

Well this may be going in yet another direction (https://github.com/ros2/rclcpp/pull/2475#discussion_r1559540603), so let's wait a bit.