vim-titlecase icon indicating copy to clipboard operation
vim-titlecase copied to clipboard
verified publisher icon christoomey

Fixed Edgecase Exclusion List Caveat

Open OneTrueC opened this issue 1 year ago • 2 comments

Not the most elegant solution, but it works.

OneTrueC avatar May 05 '24 02:05 OneTrueC

Hey @OneTrueC - thanks for putting this up.

I'd like to understand the intention of the changes better before merging in. It looks like there are two different cases you're handling, one for preserving UPPERCASE and the other for only matching the whole word for exclusion words. Is that right?

If so, I'm wondering if you can share some specific cases for these?

christoomey avatar May 05 '24 14:05 christoomey

The caveat in the readme states that the exclusion list shouldn't be ignored and uses all caps for examples, so I made my changes under the assumption that the intended behavior was to check both for the beginning and end.

As for examples:

  • the fanciful tales of HTML -> The Fanciful Tales of HTML
  • (given that thoughtbot is in the exclusion list) secrets of thoughtbot -> Secrets of thoughtbot

OneTrueC avatar May 05 '24 17:05 OneTrueC