KnobKraft-orm icon indicating copy to clipboard operation
KnobKraft-orm copied to clipboard

Published 20 hours ago • verified publisher icon christofmuc

Create JB_Solaris.py

Open conversy opened this issue 2 years ago • 2 comments

This a (still incomplete) adaptation for the John Bowen Solaris synthesizer. The adaptation is able to discover a Solaris unit, receive an Edit Buffer and find the name of the preset, but it's not able to send a preset so far, I do not know if the Solaris sysex implementation is able to accept it.

conversy avatar Oct 08 '22 19:10 conversy

@conversy Pretty cool! I will have a look at the code and see if I can spot any improvements possible! Also, if you have a single patch sysex file to upload, we can put it into the test data directory and hook the adaptation into the test suite.

christofmuc avatar Oct 12 '22 08:10 christofmuc

Thank you. For the test data, I'll do it later, I'm not able to do it for a few weeks.

conversy avatar Oct 12 '22 19:10 conversy

Hi, I uploaded a sysex file, and added some tests, though they should be completed later. Is there anything preventing this PR to be merged that I can do? Best, Stéphane.

conversy avatar Dec 31 '22 16:12 conversy

Hi Stéphane, thank you! No, everything is fine, I am just preparing the 2.0.0 beta release which sucks up my time. Will hopefully do the release today! I'll merge this in for the release!

christofmuc avatar Jan 01 '23 10:01 christofmuc