apollo-bugs icon indicating copy to clipboard operation
apollo-bugs copied to clipboard

URLs with anchors not handled correctly

Open robinsonrc opened this issue 3 years ago • 4 comments

I’m reporting this from mobile so it’s going to be brief but from what I can tell most/all URLs with anchor # components are broken in Apollo. What I suspect is happening is that the # character is being incorrectly encoded. Either way this generally results in such URLs sending the user to 404 pages.

robinsonrc avatar Feb 16 '22 12:02 robinsonrc

To add some more to this, this is an issue with a lot of characters in URLs. I think it's probably the same issue as in #1612

It also comes up in links to flags being waved by u/FlagWaverBotReborn. Apollo parses the URLs again, turning them into invalid links. An example link posted by u/FlagWaverBotReborn is "https://krikienoid.github.io/flagwaver/#?src=https%3A%2F%2Fflagwaver-cors-proxy.herokuapp.com%2Fhttps%3A%2F%2Fi.redd.it%2F8klsj6xu87j81.jpg"

Apollo re-encodes the URL, turning it into "https://krikienoid.github.io/flagwaver/%23?src=https%253A%252F%252Fflagwaver-cors-proxy.herokuapp.com%252Fhttps%253A%252F%252Fi.redd.it%252F8klsj6xu87j81.jpg". Every special character is turned into its % code.

ralphusmcgee avatar Feb 21 '22 20:02 ralphusmcgee

Came here to report this bug as well. Thanks for the great app! :-)

adamshand avatar Feb 25 '22 09:02 adamshand

To add some more to this, this is an issue with a lot of characters in URLs. I think it's probably the same issue as in #1612

It also comes up in links to flags being waved by u/FlagWaverBotReborn. Apollo parses the URLs again, turning them into invalid links. An example link posted by u/FlagWaverBotReborn is "https://krikienoid.github.io/flagwaver/#?src=https%3A%2F%2Fflagwaver-cors-proxy.herokuapp.com%2Fhttps%3A%2F%2Fi.redd.it%2F8klsj6xu87j81.jpg"

Apollo re-encodes the URL, turning it into "https://krikienoid.github.io/flagwaver/%23?src=https%253A%252F%252Fflagwaver-cors-proxy.herokuapp.com%252Fhttps%253A%252F%252Fi.redd.it%252F8klsj6xu87j81.jpg". Every special character is turned into its % code.

Yup, exactly the same issue.

minkshaman avatar Mar 17 '22 03:03 minkshaman

Looks Kirk this may be fixed soon: https://reddit.com/r/apolloapp/comments/uqsyq8/special_characters_in_links_are_treated_as_is/

anthonylavado avatar May 17 '22 14:05 anthonylavado