Christian Bundy
Christian Bundy
https://nodejs.org/docs/latest-v10.x/api/worker_threads.html#worker_threads_worker_threads We need to run Node with an extra experimental flag for this. Are there any good alternatives to keep Node 10 compat? See-also: https://github.com/ssb-js/chloride/pull/21
Some methods have accidentally been exported, even though they don't appear in Sodium-Native, which gives Sodium-JavaScript a slightly different API. The goal is to have the same API except: -...
It looks like Sodium-Native API is a subset of the libsodium API, but the Sodium-Javascript has some extra methods not found in either: - crypto_verify_16 - crypto_verify_32 - crypto_box_ZEROBYTES -...
When looking through each of the extra methods exposed by this module I noticed lots of 'wasm' mentions, but since this method doesn't mention wasm it wasn't clear to me...
Problem: In two cases the `if (ad === null)` conditions are meant to call a `_detached` method but accidentally call the non-detached counterpart. Solution: Call the corresponding function so that...
Problem: This doesn't cause a bug, when crypto_secretbox returns an integer (`0`) then the check on line 97 always fails because it checks whether the return value triple-equals `false`. Solution:...
Problem: We're passing an extra argument, which looks like it's using the method signature for `TypedArray.prototype.subarray()`, which gives you the option of setting the end of the array. Since this...
Problem: randombytes_buf uses the size of the buffer as the number of bytes to output, so we don't need to add an argument about the number of bytes we want....
Not the end of the world, but I wanted to note that it seems like most PRs after f830975aa5e32498f202c92c6c4ac77404bf28c5 have been failing in Travis. I'm not sure how to resolve...