sdc-scissor icon indicating copy to clipboard operation
sdc-scissor copied to clipboard

Magic number in interpolation

Open ChristianBirchler opened this issue 3 months ago • 0 comments

num_nodes = 50 is a code smell! https://github.com/christianbirchler-org/sdc-scissor/blob/525281fee3fc407633c0d47d9ac22b26a5a05491/sdc_scissor/testing_api/test.py#L52

Options:

  • remove the interpolation function and make the user responsible for interpolation
  • extend interface by providing an interpolation argument reflecting the number of points to sample from the interpolation

ChristianBirchler avatar Mar 08 '24 07:03 ChristianBirchler