docker-pushrm icon indicating copy to clipboard operation
docker-pushrm copied to clipboard

Add a version flag

Open larsvilhuber opened this issue 1 year ago • 2 comments

Describe the problem or bug

It's hard to know which version one has installed (tested on Linux). Standard practice is to use a "-v" / "--version" flag to report it.

docker-pushrm version

./docker-pushrm docker-cli-plugin-metadata | grep -i version
    "SchemaVersion": "0.1.0",
    "Version": "1.9.0"

Docker CLI version and platform

Client:
 Version:           24.0.5-ce
 API version:       1.43
 Go version:        go1.20.7
 Git commit:        a61e2b4c9
 Built:             Tue Jul 25 12:00:00 2023
 OS/Arch:           linux/amd64
 Context:           default

cat /etc/*release
LSB_VERSION="core-2.0-noarch:core-3.2-noarch:core-4.0-noarch:core-2.0-x86_64:core-3.2-x86_64:core-4.0-x86_64"
NAME="openSUSE Leap"
VERSION="15.4"
ID="opensuse-leap"
ID_LIKE="suse opensuse"
VERSION_ID="15.4"
PRETTY_NAME="openSUSE Leap 15.4"
ANSI_COLOR="0;32"
CPE_NAME="cpe:/o:opensuse:leap:15.4"
BUG_REPORT_URL="https://bugs.opensuse.org"
HOME_URL="https://www.opensuse.org/"
DOCUMENTATION_URL="https://en.opensuse.org/Portal:Leap"
LOGO="distributor-logo-Leap"

if possible: registry server version

not relevant

exact command that you're running

docker pushrm -v

debug output

Not relevant (new functionality)

Additional context

None. Thanks for the great plugin!

larsvilhuber avatar Nov 09 '23 14:11 larsvilhuber

just for completeness (I like your suggestion), if you use it as a Docker CLI plugin the usual way to display the installed CLI plugins with version info works as well:

$ docker --help
  ...
  pushrm*     Push Readme to container registry (Christian Korneck, 1.8.0)
  ...

christian-korneck avatar Nov 09 '23 16:11 christian-korneck

Always learn something new... I would also have thought that sincedocker version works, that something like docker pushrm version would also work, but of course it doesn't.

docker pushrm version
ERRO Invalid [IMAGE] argument - missing namespace. Example: docker.io/mynamespace/myrepo:latest 

I like -v because just about every other (Linux) command line software allows for the "-v" flag. But maybe just me...

larsvilhuber avatar Nov 09 '23 16:11 larsvilhuber