xamarin-forms-carouselview icon indicating copy to clipboard operation
xamarin-forms-carouselview copied to clipboard

vertical scrollbar option

Open PatrickSBradley opened this issue 9 years ago • 2 comments

Chris,

I discovered that i had the spaces\tabs settings in visual studio set to spaces and that was causing all kinds of diffs in the files I had changed. So I switched to tabs and now things look much better.

Added a vertical scroll option to the carousel. By default, the behavior has not changed(horizontal scroll) but now the user can switch to vertical scroll if they want to.

Pat Bradley

PatrickSBradley avatar Apr 22 '16 00:04 PatrickSBradley

I think you should make a parameter with a default value set in the constructor so it won't break compatibility. https://github.com/chrisriesgo/xamarin-forms-carouselview/pull/19/commits/cf2950a80fe3d977ec638c7068ade26ff1eb344d#diff-b332fd4efebb1d290e3cde7040afe3acR24

entdark avatar Apr 22 '16 08:04 entdark

thanks, i missed that and wll do it.

On Fri, Apr 22, 2016 at 3:34 AM, entdark [email protected] wrote:

I think you should make a parameter with a default value set in the constructor so it won't break compatibility. cf2950a#diff-b332fd4efebb1d290e3cde7040afe3acR24 https://github.com/chrisriesgo/xamarin-forms-carouselview/pull/19/commits/cf2950a80fe3d977ec638c7068ade26ff1eb344d#diff-b332fd4efebb1d290e3cde7040afe3acR24

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/chrisriesgo/xamarin-forms-carouselview/pull/19#issuecomment-213325554

PatrickSBradley avatar Apr 22 '16 22:04 PatrickSBradley