Chris O'Haver
Chris O'Haver
It’s solved for the file plugin, but I think it’s still an issue for wildcards served from other sources such as from upstream servers, or any plugin that synthesizes wildcard...
Yes, I think it's a good idea. I would prefer extending this plugin with an option over trying to do it with `k8s_external` (which seems complicated at first glance -...
I don't think this is necessary at the moment. Categorizing _valid_ names independently is how BIND works, and per my understanding, it makes sense from the perspective of being less...
That said, if we do find we need make this an option, it should only be to add/remove _qname_ from the index, and only apply to categorization of valid responses...
It will be in the next release - date TBD.
LGTM thanks! Can you sign the commit to the DCO check passes? Thanks!
Resolv.conf file monitoring isn’t a feature yet. Regarding workaround, I think sending an sig hup to coredns will do a graceful reload even if the corefile itself hasnt changed -...
Thanks for the fix!
Looks like the failed tests are related to the change. PTAL.
@osho-20, I think this looks good. Please resolve the conflicts. I think the e2e test failure is a flake unrelated to your changes. Hopefully it will pass when it re-runs...