Chris Nesbitt-Smith

Results 30 comments of Chris Nesbitt-Smith

> @rolfw > Thanks for mentioning, I wasn't aware of that. Maybe a good idea to include that in the readme of this repo as well. Is that project functionally...

> I didn't get around to experimenting with any of this yet, but I might have some time in the next week or two to see if I can get...

Syslog, use logstash or fluentd to forward it. Given the variety of options, flags etc it’s better to not bake that into the app

@rarkins https://github.com/DaftDoris/newsdesk/pull/448

@rarkins you're quite right, sorry that's a poor example this one is better: https://github.com/DaftDoris/newsdesk/pull/452

Is it 'right/necessary' that `pull_request_review.dismissed` is tightly coupled to the check results *at the time* that the review is dismissed, those can can change or be async? or even tightly...

if that was configurable somehow that'd be awesome, seems like it'd be hard and require calling back to the API to get more context than you'd get in the payload...

yeah that could work, will raise a PR, _probably_ won't cause any harm but do you have to means to test this (test version of the app install) we could...

Will have a poke around in a few days and figure the api for checking the status of the arming request unless you’ve been there before?

Presumably this https://github.com/And3rsL/VisonicAlarm2/blob/2a39df15f65c19c52b1b79bde41aa4598029f519/visonic/alarm.py#L783 ha. Turns out I wrote this in node a while ago. Thought it was familiar https://github.com/chrisns/visonic_v8/blob/0a3f773a2aea3e2f0dd887aff0b6411f19769fa0/src/alarm.ts#L224-L233 https://github.com/chrisns/visonic_v8/blob/0a3f773a2aea3e2f0dd887aff0b6411f19769fa0/src/alarm.ts#L189-L207