Chris Needham

Results 389 comments of Chris Needham

I just tried to reproduce this with a 30 minute MP3 file. It takes a long time to display the waveform, which is why we recommend using `audiowaveform` to preprocess...

I'll look into this, although I will probably drop Bower support soon (the Bower documentation [recommends moving to Webpack or Parcel](https://bower.io/docs/creating-packages/) for new projects)

Thanks, Lee. I can also confirm that the same occurs when using the Web Audio API rather than precomputed .dat files, and also in Firefox. There are two cases where...

It's not clear that this is fixable in Peaks.js (suggestions welcome), so for now converting your MP3 files to CBR is recommended.

This is the thing... I suspect there's little that can be done in this library, rewrite or otherwise. Audio playback is handled by the browser, and we use Web Audio...

I'm not sure what the right solution is here, to be honest. For now, should I simply add the `src` files back in?

The main thing I changed was to add the `"files"` field, as I noticed the npm package included the demo pages with audio files, making the package much larger than...

I have created a [branch](https://github.com/bbc/peaks.js/tree/packaging) that adds the `src` directory. I haven't included the `module` entry, as the [Webpack](https://webpack.js.org/guides/author-libraries/) and [Rollup](https://github.com/rollup/rollup/wiki/pkg.module) documentation say this module should use ES2015 module syntax....

I think perhaps I should merge this change as is, so you have a working build again. I'd like to try moving Konva.js to peerDependencies, so see if this solves...

Peaks.js build now breaks when Konva.js is updated to [8.0.0](https://github.com/konvajs/konva/blob/master/CHANGELOG.md#800) ``` > [email protected] prebuild > npm run lint > [email protected] lint > eslint src/*.js test/**/*.js test/*.js karma.conf.js > [email protected] build...