Chris Clarke

Results 55 comments of Chris Clarke

As this shouldn't have any real knock-ons elsewhere I think safe to unblock and just merge

Thanks for taking the time to look at this and the depth of solution you've worked on here. I think the main issues you've addressed are more than enough, and...

Hey @thisislawatts! Just to quickly check in, if you get a chance to review my minor comments in the next week or so that would be great, otherwise I'll just...

Thanks again @Sc4ramouche and for addressing all the suggestions. Looks good to go!

close in favour or #1987

I had the same problem, I had to remove all the lines containing `moduleId: module.id` (around 4 instances in various component decorators) and rebuild. I suggest they should be removed...

I think there's a fix for that included in #2065, so I'll try get that merged in to fix the linting issue.

Sorry this fell off my radar, thanks for weighing in on the discussion @Ulian and @davehakkens A couple points from my side > The` mappin document should be removed or...

closing as we've been using lazy-loaded bundles for quite some time

Thanks @thisislawatts! will get the release shipped asap