Chris Clarke

Results 55 comments of Chris Clarke

Need to also configure storage access rules. Currently open to all for read,write. (auth config: service firebase.storage { match /b/{bucket}/o { match /{allPaths=**} { allow read, write: if request.auth !=...

yes I think for early implementation we can pretty much have: 1. Everyone can read data from a list of collections specified (i.e. howtos, qandas etc.) 2. Only logged in...

I'm not sure how easy it will be to direct a url path to a different domain, if possible to do with a subdomain once deployed onto github pages that...

@caiokf - is this something you would be interested in looking into?

**To Include** > I wonder though how do I test this correctly : everything seems to work fine when I have a internet connexion, but as soon as I turn...

Note, if doing so can also revisit current service worker behaviour if following issue resolved: https://github.com/facebook/create-react-app/issues/5316

Another couple to consider: https://www.styled-components.com/docs/tooling#babel-plugin https://www.styled-components.com/docs/tooling#babel-macro (allow custom css property on styled components) https://github.com/timarney/react-app-rewired https://github.com/withspectrum/react-app-rewire-styled-components (cra overrides for working with things like styled components without eject)

Note, custom code currently added to ejected version to support skipWaiting (`config/webpack.config.js` L561), suggest waiting until good solution to above issue solved before any uneject

Update to skipWaiting, now possible through postMessage: https://github.com/facebook/create-react-app/issues/5316#issuecomment-496292914

Note - whilst unejecting would be good to do some housekeeping. Can use tools like [depcheck](https://www.npmjs.com/package/depcheck) to analyze unused dependencies