render_sync
render_sync copied to clipboard
chrismccord
Pubnub Adapter
I've written a Pubnub Adapter for sync and it's passing the message_tests, but I'd like to verify also that it receives the messages as it should, can you add the Basecamp style todo application to test suite so I could do some integration tests to see if it actually works?
I just checkout out your fork and it looks great! I definitely want to get integration tests set up within the test suite so we can handle new additions like this. Basically, I think we need to copy the example application linked in the readme to the test/ folder and setup something like capybara-webkit to get things rolling. On a side note with your fork, may I suggest changing the yaml configuration keys to use "generalized" keys equivalent of the Pusher example? Also, I'm not familiar with the pubnub gem, but will your Message class be able to handle synchronous calls? The preferred, default mode is async, but I want to be sure we can either handle both, or worst case just ensure that we document only async mode is supported for certain adapters. Give me a few days to get the integration suite in place as I have some other things on my list. Thanks!
Excellent, message me when the integartion tests are set up and I'll get it into the works, yeah I will fix the yaml file to be more generalized, it was a 2 hours work on this adapter so it might be passing the unit tests but I don't think it's good for production just yet :-)
I spent half of Sunday trying to get an integration suite setup with capybara-webkit and have been stumped by the capybara session failing to receive pubsub events from the server. I'm not sure what's preventing the events from being received, but in the meantime I'll be testing your PR manually so we can get this in place. Give me a day or two to get things tested out. Thanks
Sounds like @gmaliar is still interested in working on this in https://github.com/chrismccord/sync/pull/28 -- @nadeemja, maybe you two can sync up! (pun not intended)
Haha, I see what you did there! :P
I would like to offer to test the code in dev/production. @gmaliar, let me know if this might be helpful.
/Nadeem J. Qureshi, Phone: 452 22 604 Email: [email protected]
On Sat, Mar 7, 2015 at 11:43 PM, Adam Becker [email protected] wrote:
Sounds like @gmaliar https://github.com/gmaliar is still interested in working on this in #28 https://github.com/chrismccord/sync/pull/28 -- @nadeemja https://github.com/nadeemja, maybe you two can sync up!
— Reply to this email directly or view it on GitHub https://github.com/chrismccord/sync/issues/8#issuecomment-77714636.