Make autogenerated finders overridable (Skip def using Module.defines? before compile)

[chrismccord]

[scrogson]

Is this regarding the with_field_name finders? https://github.com/chrismccord/atlas/blob/master/lib/atlas/finders.ex#L30

What if we removed those in favor of a find_by/1 which takes a keyword list like ActiveRecord 4?

User.find_by(username: "bob", password: "secret")

[chrismccord]

Yes, :+1: on the removal. We want to make sure only valid keys are passed.

[chrismccord]

ie, we should raise something like Schema.UndefinedFieldError if a passed key does not map to the defined schema

[scrogson]

gotcha.