tika-python icon indicating copy to clipboard operation
tika-python copied to clipboard

Tika 1.24.1 - gzip (de)compression

Open carantunes opened this issue 4 years ago • 5 comments

Closes https://github.com/chrismattmann/tika-python/issues/305

Bump Tika to 1.24.1 Add tests for benchmarking gzip compression

carantunes avatar Jul 01 '20 14:07 carantunes

Coverage Status

Coverage increased (+2.4%) to 50.0% when pulling a18347220d3802e9f9e9e14c66145cad9dbb24bd on carantunes:rmeta-allow-gzip into d692c0ffa6b85d099019de9b94888fb4c2a48040 on chrismattmann:master.

coveralls avatar Jul 01 '20 15:07 coveralls

In another topic please consider removing support for python 2.7 as it reached EOL on January 1st, 2020 and it considerably slows downs development.

carantunes avatar Jul 01 '20 16:07 carantunes

Is travis not running anymore?

carantunes avatar Jul 01 '20 16:07 carantunes

thanks @carantunes I'll review this week. Just got back from vacation. How should I remove python2.7? I'm not *explicitly supporting it" per-se, I am using python3.7 as my core dev environment. Do you mean remove it from Travis?

chrismattmann avatar Jul 21 '20 04:07 chrismattmann

Hi, I was on vacation as well. Yes, I assumed from Travis python 2.7 support was mandatory. In that case if you wish, after this one is merged, I can contribute removing explicit python 2.7 support code segments and from Travis as well.

You can also add the explicit minimum required python version with python_requires:

setup(
...
   python_requires='>3.6',
...
)

or just hint it with a classifier:

setup(
...
    classifiers=[
        ...
        'Programming Language :: Python :: 3',
        'Programming Language :: Python :: 3.6',
        'Programming Language :: Python :: 3.7',
        'Programming Language :: Python :: 3.8',
        ...
    ],
...
)

carantunes avatar Aug 17 '20 09:08 carantunes

sorry it took me so long @carantunes! merged. Will release as part of the next release.

chrismattmann avatar Dec 31 '22 20:12 chrismattmann