ember-freestyle icon indicating copy to clipboard operation
ember-freestyle copied to clipboard

Style loading issues with freestyle page snapshot using @percy/ember

Open sepuckett86 opened this issue 3 years ago • 5 comments

I'm seeing this frequently (every other PR or so) as a Percy test failure (see image below).

There appears to be an issue with loading the font style completely before the snapshot is taken, causing the diffs.

Also, the backgrounds for the code snippets should be a dark color. This loads loads fine in our app, just not in the Percy snapshot.

So far I've tried adding test helpers like 'settled' and 'waitUntil' to the freestyle test but have so far been unsuccessful in solving this.

Thanks for any help on this - otherwise freestyle has been a great addition to our app! Not sure if this is an issue for this repo, for Percy, or if it's specific to the repo I work in.

Screen Shot 2021-03-31 at 2 20 49 PM

sepuckett86 avatar Mar 31 '21 21:03 sepuckett86

@scanieso I don't have any experience troubleshooting this particular issue, but looking at your image, it makes me wonder if the text is being styled using a webfont, and that the timing of the font loading might be a culprit?

lukemelia avatar Apr 01 '21 07:04 lukemelia

Hey @lukemelia ! I think you meant to tag @sepuckett86 :)

scanieso avatar Apr 01 '21 13:04 scanieso

Whoops, thanks @scanieso -- sorry for the errant notification! :-)

lukemelia avatar Apr 01 '21 13:04 lukemelia

@lukemelia Thanks for the response! I'll look into the font loading.

sepuckett86 avatar Apr 01 '21 14:04 sepuckett86

Hi @sepuckett86! Do you have an update on this issue?

bertdeblock avatar Oct 10 '21 13:10 bertdeblock

Going to close this one for now due to no response, feel free to reopen if this is still an issue though!

bertdeblock avatar Sep 06 '22 10:09 bertdeblock