Chris Lee

Results 124 comments of Chris Lee

@peweb, The proposed code by @shhhmel is doing the same task as what the current code does.

Interesting. So even if your account type is "MARGIN", you still can trade "SPOT"? I will update the code to check permission, not `accountType`. Or @jorisvansoest, you can open a...

Yap, I agree. I will go through the code and fix it when I get time. Don't have much time at this point.

@eppenga Oh, if you can share your code, I am happy to take it as a reference. With my changes, I think there is a performance issue. Not on my...

Before merging, - [x] Need to test upgrade from v0.0.98

This PR works as expected based on the recent trades with test settings. **Setting** ![image](https://github.com/chrisleekr/binance-trading-bot/assets/5715919/704b8415-f600-444e-8066-c311c9ccbf29) **Closed Trades** ![image](https://github.com/chrisleekr/binance-trading-bot/assets/5715919/b394315a-fc9c-4cf7-9a75-8b647d93355e) **Charts with Buy/Sell** ![image](https://github.com/chrisleekr/binance-trading-bot/assets/5715919/d4e83fb4-000a-4753-8352-0f35db882fed) ![image](https://github.com/chrisleekr/binance-trading-bot/assets/5715919/35d81f35-6ea8-448a-a4a5-8c15338127d7)

Explanation of TradingView is here - https://github.com/chrisleekr/binance-trading-bot/wiki/TradingView

@dasbts What you investigated is correct. Unfortunately, I don't have time to add a new feature.

@peweb Sounds good feature to add. I am currently refactoring TradingView. But I won't add this change at this time. Already have lots of changes.

@hiraobayed329 I think most likely invalid configuration with your API key. Are you sure you set the correct mode? https://github.com/chrisleekr/binance-trading-bot/blob/master/docker-compose.server.yml#L14 If you are using test API key, BINANCE_MODE must be...