Store Multiple Requests for Inspection

[paulbellamy]

What I did:

• Refactored @last_request into an array called @requests
• FakeWeb.last_request=(request) now appends to @requests
• FakeWeb.last_request returns @requests.last (maintains backwards compatibility)
• FakeWeb.clear_requests sets @requests to nil (clearing received requests)
• FakeWeb.requests returns @requests for inspection

Use Case: When code makes multiple requests and you care about a request other than the last one made.

Usage: - To check the last request made by a test I do FakeWeb.last_request (backwards compatible)

• To check the first request for a test I do FakeWeb.requests.first
• To check the second-last request I do FakeWeb.requests[-2]
• Etc...
• After each test (where I was doing FakeWeb.clean_registry), I add a call to FakeWeb.clear_requests

[openfirmware]

Interesting we both came up with similar solutions: https://github.com/openfirmware/fakeweb/tree/multiple_recent_requests

I like your tests better than mine, though.

[gregory-m]

+1 for this one. I also sometimes need this functionality in my specs.

[jshou]

+1!

[pat]

Excuse me pimping something of my own, but I wrote a gem some time ago that lets you set expectations on which requests have been made: https://github.com/freelancing-god/fakeweb-matcher

Granted, it's built for RSpec, but could likely also be used in TestUnit.

[jshou]

Any updates on this?