pytest-notebook icon indicating copy to clipboard operation
pytest-notebook copied to clipboard

post process or ignores before diff

Open yasirroni opened this issue 2 years ago • 1 comments

Hi, I'm a contributor of nb-clean. I use that to clean execution count and metadata of notebook before push any commit. Do you accept any contribution around skipping execution count and metadata diff? I think it haven't been implemented by you.

I think there are two possibilities.

  1. Do a post process that run git filter on the notebook before it is cleaned.
  2. Parameters to clean diff based on the given argument

Option 2 is better I think. Since nbdime support ignores

Then, the question is, does this package respect nbdime config nbdime_config.json?

yasirroni avatar Dec 27 '22 22:12 yasirroni

After some testing, it seems that pytest-notebook ignores nbdime_config.json, both on the pytest target folder and on root folder.

yasirroni avatar Dec 28 '22 01:12 yasirroni