CJPAdController icon indicating copy to clipboard operation
CJPAdController copied to clipboard

ios7+tabbarcontroller+"bottom" -> tbcView not resized correctly

Open nickbit opened this issue 11 years ago • 6 comments

ios7+tabbarcontroller+"bottom" -> tbcView not resized correctly In viewDidLayoutSubviews the tbcView frame is resized but when reentering the function the original size is back

nickbit avatar Aug 24 '13 06:08 nickbit

Any idea anyone, how to fix this?

nickbit avatar Aug 25 '13 22:08 nickbit

Confirmed the issue. No idea what the root cause of the problem is though. I logged the heights of each subview and they all get set correctly, I also changed autosizing masks but they had no effect, the height always seems to take up the rest of the view space but ignores the ad. It doesn't seem to make sense.

Building against the iOS 6.1 SDK should make it fine for now but I realise this is not an acceptable workaround since we'll all need to build for iOS 7 very soon. I'll probably have to look into implementing this a different way if I or someone else can't fix this.

chrisjp avatar Aug 26 '13 16:08 chrisjp

Hi Chris, thank you for your effort. I tried several things too, even swizzling methods, and the max I could accomplish was to change the frame once. After another tab is selected, everything jumps back to the full content size. An approach would be to have a BannerManager and a BannerViewController in the sense of the iAd suite by Apple. The manager could decide as to apply containment of the individual tabcontrollers for the case of UITabbarController + "bottom". For the other cases, a fully contained view in the BannerViewController might be OK.

nickbit avatar Aug 26 '13 17:08 nickbit

Is this issue causing the Ad Banner to be clipped? When I enable "Highlight Clipped Banners" in the Developer settings on my iOS 7.1 device, all of my test Ad banners show up in green.

stevepet avatar Apr 24 '14 13:04 stevepet

Has anyone figured out a way to fix this issue? Most of my screens incorporate a UITableView and the very last row always gets cut off.

milo-the-dev avatar Jun 18 '14 05:06 milo-the-dev

Has this issue been solved? The tab bar hides often with banner in iOS 7 and 8. The controller is really easy and helpful but this bug is making it bad. Would be really thankful if this bug is solved soon in next version. Waiting for next version of CJPAdController. Thanks

PrakashMaharjan avatar Jul 14 '15 13:07 PrakashMaharjan