Calligraphy
Calligraphy copied to clipboard
Support for italic and bold fonts using attribute textStyle
Thanks for this great project. It helped me a lot. Just one thing was missing. Support for bold and italic fonts depending on the attribute textStyle.
I forked gfranks' solution to use the native attribute textStyle for selecting bold/italic fonts.
There have been many redundancies. Therefore I refactored the changes. Additionally I fixed a bug because getTypeface() sometimes returns null.
It would be nice if you could integrate this solution. Let's just discuss about it.
Cool, thanks for the PR. I'm not a massive fan of having to define bold/italic etc. It should just work with the textStyle attr.
I'll mull this over when I have more time to spend on it.
This is really cool, Thanks
It's been 5 nice years developing apps for Android, natively, and every time I have to deal with bold/italic, I always end up with a lot of boilerplate code or juniors asking "why should I add fontPath if we didn't add it somewhere else".
Why don't we allow to define default fonts for different Typefaces and override them with fontPath?
It would make our lives really easier.
@RafaRuiz My suggestion would be to move to the Calligraphy3 if that is something you still need or use the FontProviders in AndroidX now.
My fault. I didn't realise there was a 3. Thanks!
When will this branch be merged? Because I'm also having the issue that I want to add multiple styles of a font.
@basmaessen it won't be, this fork has no active dev. I would move to https://github.com/InflationX