chrisholder

I'd like to do something with this. Could you give me a quick run down of the parameters above. This is what I am assuming: metric: str - the metric...

I've ran this on Macos and Linux without issue so maybe a windows thing if anyone can try it out?

Hi @krstopro thanks so much for the PR! Great to have a new distance! If you're struggling with anything in regards to the tests or CICD stuff feel free to...

Just an update @krstopro and I spoke on slack and he is implementing an update to make the distance symmetric (it currently isnt) and then I will finalise the tests...

@krstopro we can now support the distances not returning the same value with different x, y orders (i.e. y, x). This means we can get this in. If you're still...

I think before 1.0 we should add I better directory structure to the distance module. Currently it's just one flat directory. Currently I was thinking we should have something like:...

One key change worth documenting is in the cache script there is this step: ``` - name: Install CPU version of pytorch on linux uses: nick-fields/retry@v3 if: steps.cache.outputs.cache-hit != 'true'...

The caching doesn't exist until merged onto main (as the cache's need to be made on main). This is a run on my fork using the pip cache: 

This is the usage on this branch that doesn't have any pip caching:  Overall the caching saves a hour over all tests

For both the KNNClassifier and KNNRegressor I've replaced the _kneighbors function with a public kneighbors. There are two reasons I have made this change: 1) It simplifies the code structure...