Chris Guida
Chris Guida
Just PR it in like so: https://github.com/lightningd/plugins/pull/583 Make sure to add some CLN integration tests for the CI
@steepdawn974 closing this now that `xpay` is a thing. Feel free to reopen if you disagree.
This seems better, yeah :)
Do we still want to test master nightly to alert us of upcoming breakages? I liked your idea of doing a "diff CI" for pushes, and a "full CI" nightly.
We want two different test processes: 1) every push, we test against *only* what changed, and we pull CLN latest release binary for these tests. 2) every night, we build...
We also want to move to a system where all plugins are built from source every night, and we also want to enforce that all plugins have tests, ideally useful...
I don't know how to get @fmhoeger to appear in the list of assignees, so i'm assigning myself.
Sure, that sounds good.
Pretty sure this was solved by @daywalker90 in [various PRs](https://github.com/lightningd/plugins/pulls?q=is%3Apr+is%3Aclosed+author%3Adaywalker90+CI%3A) and [@sip-21](https://github.com/lightningd/plugins/pulls?q=is%3Apr+is%3Aclosed+author%3Asip-21) in June and July. Most notably this one https://github.com/lightningd/plugins/pull/497 And this one https://github.com/lightningd/plugins/pull/537 Closing.
Fixed in https://github.com/lightningd/plugins/pull/525