nvim-puppeteer icon indicating copy to clipboard operation
nvim-puppeteer copied to clipboard

[Bug]: Puppeteer recognizes path parameters in FastAPI routes as f-strigns

Open Popkornium18 opened this issue 2 years ago • 2 comments
trafficstars

Bug Description

When creating FastAPI routes you often write strings that look a lot like f-strings but should not be turned into f-strings automatically. See here for an example: https://fastapi.tiangolo.com/tutorial/path-params/

puppeteer turns these strings into f-strings and requires workarounds to remove the f-string

Relevant Screenshot

No response

To Reproduce

No response

neovim version

latest

Make sure you have done the following

  • [X] I have updated to the latest version of the plugin.

Popkornium18 avatar Nov 13 '23 13:11 Popkornium18

I don't feel confident fixing this, since I have no experience with FastAPI and therefore am not familiar with any potential edge cases. Should be sth via PR with someone who has actual experience with Fast API.


Just a general word of advice for when you create issues on GitHub

  1. Don't post something like version: latest. It's unclear whether it's the latest nightly or stable, and especially if the issue is read some time later, it is not clear what the latest issue was at that time. Running nvim --version in the terminal really is not much work.
  2. The "to reproduce" field is there for a reason. Post clear examples how an undesired operation looks like. Off-loading the research work how an API someone is not familiar with looks like makes it harder for anyone to work on that issue, reducing the likelihood that the issue is going to be addressed.

It's just a minor annoyance for me, so no big deal, but in bigger repos where a lot of issues are submitted, the chances are high that your issues will be closed without comment by the maintainers

chrisgrieser avatar Nov 13 '23 13:11 chrisgrieser

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment, for example "bump", and it will be kept open.

github-actions[bot] avatar May 12 '24 04:05 github-actions[bot]

This issue has been closed due to inactivity, and will not be monitored.

github-actions[bot] avatar May 19 '24 04:05 github-actions[bot]