Chris Gervang

Results 126 comments of Chris Gervang

Any feedback @ibgreen, @ilyabo, @alasarr, @Pessimistress?

It does seem inconvenient that it only resets if the view is different. A shallow comparison should work, but would also reset when the object is spread or copied.

Don't react/redux applications rely on copying even when the values haven't changed?

`initialViewStateShallow` looks good to me if it's just this prop. If deck is tracking changes for other props maybe an object to configure them all.. ``` comparisons: { initialViewState: "shallow"...

Since this is only a behavior on initialViewState, what do we think about adding a property to the view state to configure this behavior? ``` initialViewState: { ..., longitude: 90,...

Really nice behavior. The mouse scroll change is subtle but really makes a difference. I thought the pan mouse controls made a lot of sense too. What do you think...

I'm making a component that wraps `Map` and passes along any map props, so I thought to type this prop with `MapProps` like this: ```ts import Map, {MapProps} from 'react-map-gl';...

Do you know where this external controller use case is in use? I thought this was removed in v7 so that the map could only control deck, rather than the...

What do you think of adding [the kepler script](https://github.com/keplergl/kepler.gl/pull/2472) to vis.gl projects? I suppose that only works if its a consistent SPDX header. It'd be helpful for projects with one...