Chris Elrod

Results 837 comments of Chris Elrod

Hi, mind giving code I can copy and paste to run the example (and perhaps eventually add to the tests)?

The problem is that it doesn't un-alias the names. That is, creating two distinct variables with the same name (`i` or `Aij`) is likely to cause problems. It's more likely...

Hi, thanks for the issue. The two times problems can be noticed are: 1) Macro-expand time. 2) When compiling the generated function. Macro-expansion happens immediately upon defining a function. It'll...

The major obstacle to this is that the original loop expression is lost, and the `LoopSet` object doesn't preserve the original structure. It represents loops as a set of operations...

The file I linked no longer exists, and is no longer how things work. The macro now: ```julia julia> @macroexpand @avx for i ∈ eachindex(a,b) s += a[i]*b[i] end quote...

@baggepinnen , I liked your approach until: > Edit: if you want if right in front of @avx, then there's little need for a second macro on the function. The...

Perhaps something like this: ```julia check_valid_args() = true check_valid_args(::Any) = false check_valid_args(::Type{T}) where {T

My problem with that generic definition is > I don't think I should make a generic `AbstractArray` fallback with parent, because odds are that the wrapper type will need explicit...

Okay, I'm fine with being more optimistic and using the recursive `typeof(parent(A)) === typeof(A)` trick. I'll work on this tonight.

Got around to it about a day late, but I did add it yesterday, using [mcabbot's implementation](https://github.com/chriselrod/LoopVectorization.jl/blob/master/src/condense_loopset.jl#L310). Example from the unit tests, wrapper type that does not subtype `DenseArray` and...