beefy icon indicating copy to clipboard operation
beefy copied to clipboard

fixed incompatibility on node 4.1.0 on windows.

Open bunnybones1 opened this issue 8 years ago • 9 comments

I couldn't run beefy on node 4.1.0 on Windows because of something they changed in Buffer.concat. This change resolves the following error:


beefy (v2.1.5) is listening on http://127.0.0.1:9966
200    7ms       530B  / (generated)
buffer.js:229
    buf.copy(buffer, pos);
        ^

TypeError: buf.copy is not a function
    at Function.Buffer.concat (buffer.js:229:9)
    at Stream.end (C:\Users\Tomasz\AppData\Roaming\npm\node_modules\beefy\lib\accumulate-error.js:25:26)
    at _end (C:\Users\Tomasz\AppData\Roaming\npm\node_modules\beefy\node_modules\through\index.js:61:9)
    at Stream.stream.end (C:\Users\Tomasz\AppData\Roaming\npm\node_modules\beefy\node_modules\through\index.js:70:5)
    at Stream.onend (stream.js:59:10)
    at emitNone (events.js:72:20)
    at Stream.emit (events.js:166:7)
    at drain (C:\Users\Tomasz\AppData\Roaming\npm\node_modules\beefy\node_modules\through\index.js:33:23)
    at Stream.stream.queue.stream.push (C:\Users\Tomasz\AppData\Roaming\npm\node_modules\beefy\node_modules\through\index.js:41:5)
    at Stream.end (C:\Users\Tomasz\AppData\Roaming\npm\node_modules\beefy\node_modules\through\index.js:17:35)
npm ERR! Test failed.  See above for more details.

bunnybones1 avatar Oct 20 '15 18:10 bunnybones1

This is not just a windows issue, fairly sure this affects all platforms (certainly keeps breaking for me on osx now that I'm using node 4).

latentflip avatar Nov 04 '15 21:11 latentflip

Same issue with Mac osx Yosemite and Node v5.0.0

shobhitg avatar Nov 23 '15 00:11 shobhitg

I get this issue as well.

EDIT: opened a new issue #99 since it seems much broader than a minor incompatibility on Windows

dcosson avatar Dec 07 '15 06:12 dcosson

:+1: for this issue - it's causing downstream problems with stackgl projects (especially shader-school and webgl-workshop)

jacob-meacham avatar Dec 08 '15 19:12 jacob-meacham

Any reason this hasn't been merged?

yocontra avatar Dec 17 '15 20:12 yocontra

another request please for merging this - hitting the same issue with errors crashing the beefy server running my dev instance

heckj avatar Dec 29 '15 18:12 heckj

LGTM

refractalize avatar Feb 01 '16 08:02 refractalize

Yes, is also a problem on mac

okdistribute avatar Feb 02 '16 16:02 okdistribute

I bootcamp Windows 10 and OS X El Capitan and have this problem on both systems.

olsnacky avatar Mar 07 '16 23:03 olsnacky