CDMarkdownKit icon indicating copy to clipboard operation
CDMarkdownKit copied to clipboard

Crash with automatic link

Open WillBishop opened this issue 6 years ago • 3 comments

What did you do?

ℹ Please replace this with what you did.
This is unclear as I have CDMarkdownKit in a deployed application.

What did you expect to happen?

For it not to crash?

What happened instead?

It crashes with CDMarkdownAutomaticLink.regularExpression()

CDMarkdownKit Environment

CDMarkdownKit version:
Xcode version: 9.3
Swift version: 4.1
Platform(s) running CDMarkdownKit: watchOS
macOS version running Xcode: Latest

Here is the report: https://pastebin.com/umuVpw8c

WillBishop avatar Apr 26 '18 12:04 WillBishop

@WillBishop I'm sorry you experienced a crash. But without knowing the URL that was passed into the regular expression I'm quite sure how to troubleshoot this. My guess is a malformed URL was passed in. Though I could look into a more graceful failover.

chrisdhaan avatar May 01 '18 21:05 chrisdhaan

Ah ok. I’m not sure what the URL was either since I only have the crash report in Xcode. Well I haven’t gotten that crash again afaik so don’t bother with it if it’ll take too long

On 2 May 2018, 6:57 AM +0930, Christopher de Haan [email protected], wrote:

@WillBishop I'm sorry you experienced a crash. But without knowing the URL that was passed into the regular expression I'm quite sure how to troubleshoot this. My guess is a malformed URL was passed in. Though I could look into a more graceful failover. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

WillBishop avatar May 01 '18 23:05 WillBishop

I'll keep this open in case the issue pops up again. And I'll keep it in the back of my mind to see if theres a better way for error handling with that method.

chrisdhaan avatar May 01 '18 23:05 chrisdhaan