django-sql-explorer icon indicating copy to clipboard operation
django-sql-explorer copied to clipboard

Limit chart data by user specified number of rows

Open jamienoss opened this issue 2 years ago • 1 comments

@marksweb Hey, I was wondering if this is something you might be interested in?

We use this package and found it useful to graph only the result data as displayed and limited by the user specified row limit.

I added a setting for consideration for backward compatibility for existing users. If that's cool with you I'll incorporate this into the docs also.

I'll also add tests if you're cool with the changes in this PR.

jamienoss avatar Oct 19 '23 15:10 jamienoss

Hi @jamienoss - that does indeed sound useful to general users. Please proceed!

And if you're a discord user, on the official django discord today & tomorrow we're running a sprint for various projects, this one included. So feel free to join and share what you're building. https://discord.gg/xcRH6mN4fa

marksweb avatar Oct 19 '23 16:10 marksweb

@jamienoss I addressed this here:

https://github.com/explorerhq/sql-explorer/commit/5bb7c16130f01cbe622f99af2113d756b45800de

I took a slightly different approach, and simply respected the same row count restriction used in the preview pane.

Thanks for this good idea and apologies it took the better part of a year to get it integrated!

chrisclark avatar Aug 02 '24 17:08 chrisclark