django-sql-explorer icon indicating copy to clipboard operation
django-sql-explorer copied to clipboard

Celery 5.0 support

Open jottunn opened this issue 4 years ago • 2 comments

Any plans for it?

jottunn avatar Feb 23 '21 13:02 jottunn

@jottunn Still using celery 4 on all projects here. Although I don't actually use any of the celery features of this app.

What would celery 5 mean for the project?

Their change log basically just looks like they've dropped for support for all sorts.

marksweb avatar Feb 23 '21 14:02 marksweb

Looking into celery 5 implementation along with django-celery-results to replace djcelery. I'm not yet clear how third party apps should define tasks in celery 5.

No longer is it valid to do;

from celery import task


@task
def my_task()
    pass

You now have to import a task from the project's celery instance which I gather to be along the lines of;

from project import celery


@app.task
def my_task():
    pass

But it's not for third party packages to be defining the instance of celery, the broker etc. That's all for the project which installs the application.

I'm hoping there's some way to integrate settings to get around this, but the docs are focused on the perspective of the project author, rather than the package author.

marksweb avatar Sep 29 '21 11:09 marksweb

This is now being discussed in #493

marksweb avatar Nov 04 '22 23:11 marksweb