Christian Brabandt
Christian Brabandt
can you add a few tests for: - `set pumordering=` (empty) - `set pumordering=word,kind` - `set pumordering=word` - `set pumordering=extra` - `set pumordering=does-not-exists`
> I would say the current behavior for this case `set pumordering=extra` is kinda weird. What do you mean with it? > I could make it so that `word`, and...
> If user do this set pumordering=extra, only the extra will show up. Yes, it might be weird, and it sounds like a "don't complain if you use this setting...
I think this is a nice addition. I think we should call it `getline_region()` so that it comes close to the description of the `getline()` function. However, we need tests...
Thinking about this some more, does it handle block mode correctly? I mean for a text like this: ``` one foobar a ``` With `:call cursor(1,1)`, how do we get...
> > How about to add functionality to specify the way to get text such as charwise, linewise, and blockwise? > > For example, add a optional third argument in...
> > I think we should explicitly allow for a blockmode option therefore > > Well, I should add the argument? Yes please. Something like this: ``` getregion({pos1}, {pos2}, {dict})...
I think it's almost good :) Just a few more tests for the different `type()` values as Yegappan suggested.
> Why doesn't this return a list of positions? Return text is the least useful part about a region. The functionality of this function was to be to get the...
correct and `visualmode()`