changesPlugin icon indicating copy to clipboard operation
changesPlugin copied to clipboard

seems not working in neovim

Open chunxuan-hs opened this issue 2 years ago • 11 comments

I installed the plugin in neovim (0.9) in mac.

With :EC I got a message like this:

Changes.vim: overwrite /var/folders/ct/gbl89k5s7s74t2p7s_x_ywp80000gn/T/nvim.chunxuan/14AHWL/1.old.txt? (y/n [n]) not over
written

More info with :CC

Error detected while processing function changes#Output:
line    6:
E731: using Dictionary as a String
line    7:
E731: using Dictionary as a String
line    8:
E731: using Dictionary as a String

The inidicator are not shown. Any ideas for potential issues?

chunxuan-hs avatar May 15 '23 15:05 chunxuan-hs

Hmmmm, I'll have to check with Neovim

chrisbra avatar May 15 '23 15:05 chrisbra

It works on Neovim in both, stable and nightly versions.

Here is my configuration for Lazy Plugin Manager, you can adapt it for Packer or other Plugin Manager.

{
	'chrisbra/changesplugin',
	config = function()
		vim.g.changes_add_sign = '│'
		vim.g.changes_delete_sign = '│'
		vim.g.changes_modified_sign = '│'
		vim.g.changes_vcs_system = 'git'
		vim.g.changeslineoverview = 1
		vim.g.changes_respect_signcolumn = 1
		vim.g.changes_fixed_sign_column = 1
	end,
},

@chrisbra, I know this is not related to the problem of functioning in Neovim, but I'll take advantage of the comment.

My question is: is there a possibility to have hl-LineNr for the current plugin highlights? For example:

ChangesSignTextAddNr
ChangesSignTextDelNr
ChangesSignTextChNr

Or something like that, I have configured Neovim to not use the SignColumn and instead use the LineNumber with colours to show changes, is it possible to do this?, because I have recently done this configuration of not using the SignColumn and the plugin always works fine with the SignColumn, but I can't find a way to get the changes to be reflected in the LineNumber, Is this possible?

Fausto-Korpsvart avatar Aug 02 '23 19:08 Fausto-Korpsvart

@Fausto-Korpsvart Thanks for the comments. On my sides, the sign only show once, and disappear for additional edits.

chunxuan-hs avatar Aug 03 '23 14:08 chunxuan-hs

@Fausto-Korpsvart Thanks for the comments. On my sides, the sign only show once, and disappear for additional edits.

@chunxuan-hs, That's strange, I haven't had any problems with this plugin, this is one of the plugins I always install when I change my configuration thanks to the option to show changes in files that don't have a git repo.

Have you checked the options you have set for Neovim or auto commands? Are you using a plugin to manage the SignColumn? I remember with the StatusCol Plugin or something like that, I was seeing this behaviour.

Maybe by trying a minimal installation, you can check where the problem is coming from.

Fausto-Korpsvart avatar Aug 03 '23 16:08 Fausto-Korpsvart

I have tried the config (init.vim) with only changesPlugin

call plug#begin('~/.config/nvim/plugged')
Plug 'chrisbra/changesplugin'
call plug#end()

Still only see the sign on the first edit.

chunxuan-hs avatar Aug 03 '23 17:08 chunxuan-hs

Hi, what exactly do you mean with:

My question is: is there a possibility to have hl-LineNr for the current plugin highlights? For example:

ChangesSignTextAddNr ChangesSignTextDelNr ChangesSignTextChNr

I know I haven't updated the plugin in a while, but it should be more or less stable. Not sure why it would go away after the first edit that @chunxuan-hs mentioend, sorry.

chrisbra avatar Aug 09 '23 20:08 chrisbra

Hi, what exactly do you mean with:

My question is: is there a possibility to have hl-LineNr for the current plugin highlights? For example: ChangesSignTextAddNr ChangesSignTextDelNr ChangesSignTextChNr

I know I haven't updated the plugin in a while, but it should be more or less stable. Not sure why it would go away after the first edit that @chunxuan-hs mentioend, sorry.

Greetings, @chrisbra.

No, no, for me the plugin works perfectly, my question is if there is a possibility to add highlighting for numbers, like in hl-LineNr. I don't use the SignColumn to see the signs, for example to see the git diffs, I have set the numbers to highlight the modified lines, so I was wondering if there is an option for this plugin to highlight the numbers instead of seeing the signs in the SignColumn.

Fausto-Korpsvart avatar Aug 09 '23 21:08 Fausto-Korpsvart

okay. Can you please show a screenshot of how it currently looks? Thanks

chrisbra avatar Aug 10 '23 15:08 chrisbra

okay. Can you please show a screenshot of how it currently looks? Thanks

This is how it looks with SingColumn activated.

changes-plugin-00

And with the SignColumn deactivated, it would be great if you could highlight the numbers with colours instead of the Signs; something like this:

changes-plugin-01

Fausto-Korpsvart avatar Aug 10 '23 17:08 Fausto-Korpsvart

ah okay. So this is with :set signcolumn=no? I believe the numbers cannot individually be highlighted. Or is this differently in Neovim?

chrisbra avatar Aug 11 '23 17:08 chrisbra

ah okay. So this is with :set signcolumn=no? I believe the numbers cannot individually be highlighted. Or is this differently in Neovim?

Yes indeed, in the second screenshot it is the GitSigns plugin that I have configured to make the changes highlight the numbers.

As I said before, I recently use a configuration without SignColumn to have a little more space when I have several buffers open, and the Changes Plugin is very useful to check changes when I don't have git in the directory, that's why I was asking for this functionality in the plugin.

Fausto-Korpsvart avatar Aug 12 '23 14:08 Fausto-Korpsvart