php-resque icon indicating copy to clipboard operation
php-resque copied to clipboard

Set job timestamp to ISO 8601 format so it can be properly 'relatized'

Open richardkmiller opened this issue 12 years ago • 5 comments

This is a tiny thing, but resque-web wasn't showing relative dates, e.g. "just now", with the current date format. I changed it to ISO 8601 to play better with resque-web's jQuery relatize_date.

richardkmiller avatar Mar 12 '13 23:03 richardkmiller

It looks like this was a change made to Resque a few months ago: https://github.com/defunkt/resque/commit/df08385c1f84d34ae60ad9d35f9d9c4c18e701ab

Don't suppose you know if it's been released as such?

I'd like to bring this in, but it looks like a backwards incompatible change with older versions of Resque. I'd say 1.3 (next release) is the best one because there are already other compatibility breaking changes.

Thanks for this. :thumbsup:

chrisboulton avatar Mar 14 '13 12:03 chrisboulton

Interestingly, I changed the date format to ISO 8601 so it would work, not knowing that it was also being changed in [Ruby] Resque. We're using Resque 1.23.0 from Ubuntu 12.04 gems and that change is not yet present.

Releasing with 1.3 works for me.

richardkmiller avatar Mar 14 '13 15:03 richardkmiller

Can you please update your PR so that it also includes the timestamp set in lib/Resque/Failure/Redis.php?

$data->failed_at = date('c');

I'm using the dev-master version of PHP-Resque so I'd like to see this merged :)

ruudk avatar Mar 27 '13 09:03 ruudk

@ruudk Thanks for the heads up! Done.

richardkmiller avatar Mar 27 '13 14:03 richardkmiller

1.3 is still looming. It would probably be good to define it and get the Internet working on churning out the code to get it released.

danhunsaker avatar Dec 18 '13 14:12 danhunsaker