php-resque icon indicating copy to clipboard operation
php-resque copied to clipboard

新增auth支持

Open ghost opened this issue 8 years ago • 2 comments

ghost avatar Feb 17 '17 10:02 ghost

One of the changes here seems helpful, namely the use of PID tracking to ensure better "thread safety" across forks.

That said, all the rest are breaking changes. Some bugfixes are reverted, and many features are removed. I suspect the changes in this PR were made to a much older version of the code than the most recent version in master.

Additionally, your second commit changes the namespace of the package, which cannot be accepted.

To address this, please close this PR, create a new branch even with the master branch of chrisboulton/php-resque (this repo), and make your changes on that branch before opening a new PR for just those changes. Remember, when you make a commit to a PR's branch, GitHub adds that commit to that PR.

danhunsaker avatar Feb 17 '17 13:02 danhunsaker

I'm sure this is obvious in the code, but the PR title translates to Added auth support

PreciselyAlyss avatar Apr 11 '17 21:04 PreciselyAlyss