php-resque-scheduler
php-resque-scheduler copied to clipboard
chrisboulton
Tagging releases
Ever heard of tagging releases? It’s really handy, it allows you to mark a given commit as stable, which allows people to use the software without requiring dev-master and suffer from the weathercock behaviour of some contributors, like this:
https://github.com/chrisboulton/php-resque-scheduler/commit/f1a5596f81269809a53a7858355600e226990a9b Fixing zrangebyscore. (which is in fact breaking it) https://github.com/chrisboulton/php-resque-scheduler/commit/37ea2e2a545af6e312986638480998ef7d848d61 Removing unneeded fix in last commit. https://github.com/chrisboulton/php-resque-scheduler/commit/110e213b5f6c5368b5ac8f3cd1067898b2eac03e Revert "Removing unneeded fix in last commit." (which was a really stupid thing to do)
Today I’m hit with https://github.com/chrisboulton/php-resque/issues/50 and I can’t fix it because I should switch php-resque to dev-master, which requires me to use php-resque-scheduler in dev-master, which is broken because of the above example.
Guess what? Releases have been tagged. Ever heard of not being a jerk to project maintainers?
As to the example you cited above, it's actually more complicated than that. Differences between Credis and the php-redis extension mean that users without the extension need the unfixed code, and users with it need the fix. So now we have to either do Credis's job for it and detect whether the extension is active, then choose the appropriate call, or get the Credis devs to update their code to properly handle the call. With all three projects going a bit stale due to time limitations for those with commit rights, this will be tricky, but we're working on it.
If you need this right this second, create a fork and handle it there. That's what forks are for. But try to be a little less antagonsitic toward the maintainers of a project you intend to use, and get support for.
Guess what? Releases have been tagged.
Oh yes, I see that php-resque was tagged 1.2 on Oct 13, 2012. Wow.
Ever heard of not being a jerk to project maintainers?
Yes, I do that.
I turn it off after a threshold number of facepalms is reached, though, for survival.
If you need this right this second, create a fork and handle it there. That's what forks are for. But try to be a little less antagonsitic toward the maintainers of a project you intend to use, and get support for.
There’s a misunderstanding: I don’t intend to use this anymore, let alone get support for it.
So that people considering using this are warned that it’s not useable, and don’t lose the same amount of time I did.
What is the status on this? I am trying to install this for the first time and I am getting a notice and warning.
Warning: strlen() expects parameter 1 to be string, array given in /var/www/SalesIndicator/ext/colinmollenhour/credis/Client.php on line 1110
Notice: Array to string conversion in /var/www/SalesIndicator/ext/colinmollenhour/credis/Client.php on line 1110
