php-diff icon indicating copy to clipboard operation
php-diff copied to clipboard

Namespacing

Open jbrooksuk opened this issue 10 years ago • 6 comments

I notice that this project was last updated 9 months ago and has several outstanding pull requests, so I'm reluctant to make this change if you're no longer maintaining this project.

To make php-diff work with Laravel, it need to be in a namespace. If I make this change, would you merge it, or should I just fork and maintain my own copy?

jbrooksuk avatar Jul 10 '14 08:07 jbrooksuk

@jbrooksuk I would be interested in this change. Have you done anything with it yet?

JayBizzle avatar Aug 15 '14 10:08 JayBizzle

@JayBizzle (great name by the way) - I started writing my own version, but ended up running out of time, so no progress so far.

jbrooksuk avatar Aug 15 '14 10:08 jbrooksuk

No worries. Might have to take a look at it myself, need it for a Laravel project soon. I'll update this thread if I get anywhere with it

JayBizzle avatar Aug 15 '14 10:08 JayBizzle

Cool, I look forward to it.

jbrooksuk avatar Aug 15 '14 10:08 jbrooksuk

Old thread, I know. I've been using actinarium/php-diff for namespace support in this project, but it seems abandoned and well beyond its predecessors now.

If anyone knows of a well maintained fork that is namespaced, please let me know.

timwhitlock avatar Aug 21 '15 18:08 timwhitlock

I wound up here after trying to work with https://github.com/adaptivemedia/php-text-difference that also does the same thing. We really need one brave volunteer to merge all of these forks and maintain this thing!

hackel avatar Dec 18 '15 04:12 hackel