php-diff icon indicating copy to clipboard operation
php-diff copied to clipboard

Inline Style: $toLine in wrong <th>

Open MathiasGmeiner opened this issue 11 years ago • 1 comments

I have changed the $toLine placement from the left

to the right in inline.php on line number 131.

From:

foreach($change['changed']['lines'] as $no => $line) {
 $toLine = $change['changed']['offset'] + $no + 1;
 $html .= '<tr>';
 $html .= '<th>'.$toLine.'</th>';
 $html .= '<th>&nbsp;</th>';
 $html .= '<td class="Right"><span>'.$line.'</span></td>';
 $html .= '</tr>';
}

To:

foreach($change['changed']['lines'] as $no => $line) {
 $toLine = $change['changed']['offset'] + $no + 1;
 $html .= '<tr>';
 $html .= '<th>&nbsp;</th>';
 $html .= '<th>'.$toLine.'</th>';
 $html .= '<td class="Right"><span>'.$line.'</span></td>';
 $html .= '</tr>';
}

MathiasGmeiner avatar May 27 '13 08:05 MathiasGmeiner

PR in #17

kachar avatar Oct 21 '13 14:10 kachar