tunarr icon indicating copy to clipboard operation
tunarr copied to clipboard

Improve InlineModal performance

Open chrisbenincasa opened this issue 1 year ago • 2 comments

Some things I've noticed while working here:

  1. The component re-renders a lot. There are a lot of potential causes here
  2. It seems like we "over mount"; I think this is related to 1. having to have the components in tree in order for animations to be smooth and also 2. modal 'index' doesn't necessarily match the index of the item being displayed, which complicates things. That said, the animation isn't smooth for other reasons, so perhaps we should stop rendering all of these for now until we can figure out another way
  3. The InlineModal overexpands and then retracts on initial open animation. I think this is related to the height estimation code, but I'm not sure.

chrisbenincasa avatar Apr 29 '24 19:04 chrisbenincasa

Wonder if we're over-using useEffect in these components

chrisbenincasa avatar Jun 07 '24 02:06 chrisbenincasa

We have some huge improvements in performance here on the Jellyfin branch.

chrisbenincasa avatar Aug 19 '24 13:08 chrisbenincasa