imgcache.js icon indicating copy to clipboard operation
imgcache.js copied to clipboard

Is this plugin available to install from cordova plugin command?

Open caio-ribeiro-pereira opened this issue 9 years ago • 14 comments

Is this plugin available to install from cordova plugin command?

Because I have a meteor project which uses cordova too and I need to install this plugin using the command:

meteor add cordova:imgcache.js@version

and to install it, this plugin needs to be available into https://build.phonegap.com/plugins

caio-ribeiro-pereira avatar May 25 '15 14:05 caio-ribeiro-pereira

?

caio-ribeiro-pereira avatar Jun 03 '15 14:06 caio-ribeiro-pereira

Hey,

Imho, imgcache.js has no reason to be a Cordova/PhoneGap plugin, since it does not have a single line of native code, unlike most (all?) Cordova/PhoneGap plugins.

I know nothing about Meteor, but can't you use something like this?

BrunoCartier avatar Jun 03 '15 15:06 BrunoCartier

Hi @BrunoCartier if imgcache.js be published by atmosphere like you published for bower will be enough for my needs It does not matter if this plugin is not a cordova/phonegap plugin for me.

Can you publish this plugin into atmospherejs.com ? Thanks!

caio-ribeiro-pereira avatar Jun 03 '15 15:06 caio-ribeiro-pereira

The link I sent you before is a Meteor plugin, published on AtmosphereJS.com. It allows you to use Bower packages (imgcache.js for example) without them being registered on AtmosphereJS.

imgcache.js is (approximately) framework-agnostic. AtmosphereJS seems to be only for Meteor plugins. So imgcache.js has nothing to do on AtmosphereJS.

Please give a try to meteor-bower.

Very sorry if I miss something, as I said before, I write without really knowing what I'm talking about.

BrunoCartier avatar Jun 03 '15 15:06 BrunoCartier

@BrunoCartier you can reuse imgcache.js into meteor without changing too much. You just need to write a packages.js for meteor package description and create an account into meteor developers to publish there. You won't change the imgcache.js context, you just will extend it for meteor developers uses, like jQuery is, Underscore is and many others are.

caio-ribeiro-pereira avatar Jun 03 '15 15:06 caio-ribeiro-pereira

Okay, then this is a good idea :)

I invite you to submit a pull request with the packages.js file, that @chrisben, the maintainer of this repository, will be able to review and if all is good, accept.

BrunoCartier avatar Jun 03 '15 15:06 BrunoCartier

Nice, I will do it soon, but to publish the package the maintainer needs to create a meteor developer accounts.

caio-ribeiro-pereira avatar Jun 03 '15 15:06 caio-ribeiro-pereira

I've published a package in atmosphere chrisben:[email protected]; it doesn't show up on the search results yet. Never used that before so I'm not sure if that's enough for you to work on. I didn't add js unit tests for instance. I'll try the autopublish another time to help out in the process. Let me know.

chrisben avatar Jun 03 '15 20:06 chrisben

Nice! Thanks a lot @chrisben I added into my meteor project as a common lib and works fine, now I'll remove it to install from atmosphere.

caio-ribeiro-pereira avatar Jun 03 '15 20:06 caio-ribeiro-pereira

Hi again, it's not working from atmospherejs, I just installed well and when I use the code, it shows the error: Uncaught ReferenceError: ImgCache is not defined.

caio-ribeiro-pereira avatar Jun 03 '15 20:06 caio-ribeiro-pereira

I didn't see the package.js in both branches, it needed to setup the lib load

caio-ribeiro-pereira avatar Jun 03 '15 21:06 caio-ribeiro-pereira

I'm getting the error @caio-ribeiro-pereira mentioned on June 3 ("ReferenceError: ImgCache is not defined"). I'm not understanding what you did to fix this. Can you elaborate?

MastaBaba avatar Sep 15 '15 01:09 MastaBaba

Hi, I'm also getting this same error when using this plugin on Meteor, any fix yet? Thanks in advance!

jerocosio avatar Oct 23 '15 01:10 jerocosio

Is this problem fixed now that pull request #115 has been merged? There's a new 1.0rc2 version out there.

chrisben avatar Oct 31 '15 16:10 chrisben