kirby-navigation icon indicating copy to clipboard operation
kirby-navigation copied to clipboard

4.0 Compatibility

Open JerikoOne opened this issue 1 year ago • 7 comments

Currently the plugin is not compatible with 4.0 (as of writing this issue: Beta 1):

The API route isn't working image

The select isn't styled correctly image

JerikoOne avatar Sep 22 '23 20:09 JerikoOne

@chrisbeluga To fix you could add the following styles

.navigation-field .k-dropdown-content {
  --button-height: auto;
}

distantnative avatar Nov 23 '23 07:11 distantnative

@distantnative Unf, doesn't work.

afbora avatar Dec 08 '23 12:12 afbora

Also getting alert for K4:

Deprecated: will be removed in a future version. Since Kirby 4.0, you don't need it anymore as wrapper element. Use <k-dropdown-content> as standalone instead. Deprecated: : align prop will be removed in a future version. Use the alignX prop instead. Deprecated: : the theme prop will be removed in a future version. For help text, add .k-help " CSS class instead.

afbora avatar Dec 08 '23 12:12 afbora

Do we have a new forked maintained version?

cselex avatar Dec 26 '23 17:12 cselex

Unf not yet.

afbora avatar Dec 26 '23 18:12 afbora

I managed to get it to work. Unfortunately I'm not that in into Vuejs and Kirbys plugin structure, so do not 100% understand, WHY it works - but does :D It seemes, that in Kirby 4 the plugin in the current state builds and adds the modal for adding pages to the menu correctly, but the overlay with this modal is not opened.

You have to add three lines of code, so the overlay with the desired overlay will open up:

File: site\plugins\kirby-navigation-main\src\Field.vue image

Perhaps someone with deeper understanding of Vuejs and Kirbys plugin system can explain, why this works? :)

To fix the dropdown menu, when clicking on "Add", you have to add the following:

File: site\plugins\kirby-navigation-main\src\Field.vue image

lukas-dne avatar Jun 01 '24 12:06 lukas-dne

What would have to be done for an "official" Kirby4 compatible version? Does anyone need a small bounty?

sachbearbeiter avatar Jun 20 '24 15:06 sachbearbeiter