impetus icon indicating copy to clipboard operation
impetus copied to clipboard

Major memory leaks

Open firasdib opened this issue 7 years ago • 3 comments

You're adding events with specific flags here:

https://github.com/chrisbateman/impetus/blob/master/src/Impetus.js#L194-L198

They need to be removed with the same flags here:

https://github.com/chrisbateman/impetus/blob/master/src/Impetus.js#L238-L242

You must also ensure these events are removed when destroying the instance.

This is a huge issue for us right now and its causing all touch move events to be swallowed up by this, blocking our app.

firasdib avatar Sep 28 '18 09:09 firasdib

See https://github.com/chrisbateman/impetus/pull/41

firasdib avatar Sep 28 '18 09:09 firasdib

Also this:

[Intervention] Ignored attempt to cancel a touchmove event with cancelable=false, for example because scrolling is in progress and cannot be interrupted.

firasdib avatar Sep 28 '18 10:09 firasdib

@firasdib with the merging of #41, this can be closed now, right?

weotch avatar Jun 04 '19 16:06 weotch