gradle-mvn-push icon indicating copy to clipboard operation
gradle-mvn-push copied to clipboard

Fixed issue #28

Open ok3141 opened this issue 10 years ago • 8 comments

I also added property POM_DEVELOPER_EMAIL and disabled failing build in case of javadoc errors appears.

ok3141 avatar Jun 11 '14 11:06 ok3141

Shouldn't it be android.sourceSets.main.java.sourceFiles, not android.sourceSets.main.java.source?

Plugin Source Reference: https://android.googlesource.com/platform/tools/base/+/gradle_0.11.1/build-system/gradle/src/main/groovy/com/android/build/gradle/internal/api/DefaultAndroidSourceDirectorySet.java

cocoahero avatar Jun 11 '14 13:06 cocoahero

maybe :) but .source works for me

ok3141 avatar Jun 11 '14 13:06 ok3141

Strange that .source works. Unless I'm missing something obvious, that property doesn't exist. XD

cocoahero avatar Jun 11 '14 13:06 cocoahero

please, correct my patch if I'm wrong. because I'm actually noob in groovy

ok3141 avatar Jun 11 '14 13:06 ok3141

You're not necessarily wrong, because you're right that it works. I'm just really confused as to why it works. I'm a total groovy noob as well, which is why I wouldn't be surprised if there is some magic somewhere that is adding that .source property.

cocoahero avatar Jun 11 '14 13:06 cocoahero

Also, might be worth while adding in this patch as well, is the auto-linking to the Android documentation for referenced classes.

task androidJavadocs(type: Javadoc) {
    /* ... */
    options {
        linksOffline "http://d.android.com/reference", "${android.sdkDirectory}/docs/reference"
    }
    exclude '**/R.html', '**/R.*.html'
}

cocoahero avatar Jun 11 '14 13:06 cocoahero

@cocoahero well, you was right. google-guys answered about the same thing: https://code.google.com/p/android/issues/detail?id=71174#c3

ok3141 avatar Jun 11 '14 17:06 ok3141

@ok3141 @cocoahero your commits merged to https://github.com/Vorlonsoft/GradleMavenPush

AlexanderLS avatar Jul 19 '18 14:07 AlexanderLS