fishplot icon indicating copy to clipboard operation
fishplot copied to clipboard

Size of clone annotation labels in fishplot

Open davidkundrat opened this issue 5 years ago • 4 comments

Good day to all! I thought I would solve this easy problem myslef, but I cannot find a way to change the size of clone annotation labels that can be put into fishplot. I know how to change their color and angle but size option is not included in function "createFishObject". I have tried to poke into "fishPlot" function as well, but there is no way of modifying this size as far as I know. I would be grateful for any suggestions/tips. Thanks for reply in advance.

Best regards, David Kundrat

davidkundrat avatar Feb 18 '20 09:02 davidkundrat

Right, that's not a configurable option at present. Happy to accept pull requests if you'd like to hack that feature in!

chrisamiller avatar Mar 13 '20 15:03 chrisamiller

Hi Chris, I've got a fork that adds this functionality as well as a bit more, I was planning on submitting a pull request for it soon.

jenny-draper avatar Feb 01 '21 22:02 jenny-draper

fantastic! happy to look it over if you make a PR

chrisamiller avatar Feb 01 '21 22:02 chrisamiller

To anyone looking for this functionality, it should now be available via the argument clone.annots.cex; there's an example in the test file test.R

fish = createFishObject(frac.table,parents,
                        timepoints=timepoints, 
                        clone.labels=clone.labels, clone.annots=clone.annots, 
                        clone.annots.cex=1.5, clone.annots.pos=3, clone.annots.offset=0.5, clone.annots.col="blue")

jenny-draper avatar Mar 30 '21 02:03 jenny-draper

Closed in https://github.com/chrisamiller/fishplot/pull/26 Thanks again for the contribution!

chrisamiller avatar Feb 27 '23 04:02 chrisamiller